lr: add myself (@kisik21) as maintainer#67642
Merged
grahamc merged 1 commit intoNixOS:masterfrom Aug 28, 2019
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
As an answer to NixOS#67638, I'm adopting this package, adding myself as a maintainer.
vikanezrimaya
force-pushed
the
lr-maintainership
branch
from
09f4b8e to
cd7142b
Compare
jonringer
approved these changes
Aug 28, 2019
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
nix-review passes on NixOS (No rebuilds)
diff LGTM
grahamc
reviewed
Aug 28, 2019
| vika_nezrimaya = { | ||
| email = "vika@fireburn.ru"; | ||
| github = "kisik21"; | ||
| githubId = 7953163; |
Member
There was a problem hiding this comment.
✔️ verified it matches https://api.github.com/users/kisik21
grahamc
reviewed
Aug 28, 2019
| githubId = 7953163; | ||
| name = "Vika Shleina"; | ||
| keys = [{ | ||
| longkeyid = "rsa4096/0x5402B9B5497BACDB"; |
Member
There was a problem hiding this comment.
✔️ the longkeyid matches the key used to sign this commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As an answer to #67638, I'm adopting this package, adding myself as a maintainer.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
There was no maintainer before me, so... do I need to do that to myself? 😄